]> err.no Git - linux-2.6/commit
[POWERPC] Celleb: bug fix caused by not casting pointer types
authorIshizaki Kou <kou.ishizaki@toshiba.co.jp>
Fri, 2 Mar 2007 07:59:25 +0000 (16:59 +0900)
committerPaul Mackerras <paulus@samba.org>
Wed, 7 Mar 2007 17:09:33 +0000 (04:09 +1100)
commit8388374f1cd45ef67039d3ea128d250fac484df3
tree6fee84637f5172705708ea220d73c99c3521c25a
parentc99176a230097b076c2f98e4bf963399fe114ffd
[POWERPC] Celleb: bug fix caused by not casting pointer types

This fixes a bug caused by changes of pointer type in
commit f1fda89522c5aaa1bd4ef69605e85e6ee9c85faf.

hose->cfg_addr type is "volatile unsigned int __iomem *", so
"hose->cfg_addr + X" will not make an intended address.

This patch also adds comments for usage of cfg_addr and cfg_data in
pci_controller structure.  We use them in irregular way, and the
original code is short of explanations about them.

Signed-off-by: Kou Ishizaki <kou.ishizaki@toshiba.co.jp>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Paul Mackerras <paulus@samba.org>
arch/powerpc/platforms/celleb/scc_epci.c