]> err.no Git - linux-2.6/commit
IB/ehca: handle negative return value from ibmebus_request_irq() properly
authorHoang-Nam Nguyen <hnguyen@linux.vnet.ibm.com>
Tue, 29 Apr 2008 20:46:52 +0000 (13:46 -0700)
committerRoland Dreier <rolandd@cisco.com>
Tue, 29 Apr 2008 20:46:52 +0000 (13:46 -0700)
commit7df109d917e85d3da2e25bd495c4997e87ed2a4e
tree6eac844aee0badb05ac40dbfe1b3fe142e9d9f09
parentf8b0dfd15277974b5c9f3ff17f9e3ab6fdbe45ee
IB/ehca: handle negative return value from ibmebus_request_irq() properly

ehca_create_eq() was assigning a signed return value to an unsiged
local variable and then checking if the variable was < 0, which meant
that errors were always ignored.  Fix this by using one variable for
signed integer return values and another for u64 hcall return values.

Bug originally found by Roel Kluin <12o3l@tiscali.nl>.

Signed-off-by: Hoang-Nam Nguyen <hnguyen@de.ibm.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
drivers/infiniband/hw/ehca/ehca_eq.c