]> err.no Git - linux-2.6/commit
IB/cm: Fix infiniband_cm class kobject ref counting
authorRoland Dreier <rolandd@cisco.com>
Tue, 12 Feb 2008 22:38:27 +0000 (14:38 -0800)
committerRoland Dreier <rolandd@cisco.com>
Tue, 12 Feb 2008 22:38:27 +0000 (14:38 -0800)
commit7c7a9bccd2ba9f17e4b588461f140578a0a7b073
tree97a8a5e88339a5defa770c19466190b8a20c0943
parentab64b960673250518e748f8b4f1545447136b68b
IB/cm: Fix infiniband_cm class kobject ref counting

Commit 9af57b7a ("IB/cm: Add basic performance counters") introduced a
bug in how the reference count for cm_class.subsys.kobj was handled:
the path that released a device did a kobject_put() on that kobject, but
there was no kobject_get() in the path the handles adding a device.  So
the reference count ended up too low, which leads to bad things.  Fix up
and simplify the reference counting to avoid this.

(Actually, I introduced the bug when fixing the patch up to match some
of Greg's kobject changes, but who's counting)

Signed-off-by: Roland Dreier <rolandd@cisco.com>
drivers/infiniband/core/cm.c