]> err.no Git - linux-2.6/commit
[ICMP]: Dst entry leak in icmp_send host re-lookup code (v2).
authorPavel Emelyanov <xemul@openvz.org>
Wed, 26 Mar 2008 09:27:09 +0000 (02:27 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 26 Mar 2008 09:27:09 +0000 (02:27 -0700)
commit7c0ecc4c4f8fd90988aab8a95297b9c0038b6160
tree3c937731c0bf2c3ddfd94e2141d83af596f98d9e
parent5c2e2e239ebe44e3fdc5f2ae270d96c4ceee4e9a
[ICMP]: Dst entry leak in icmp_send host re-lookup code (v2).

Commit 8b7817f3a959ed99d7443afc12f78a7e1fcc2063 ([IPSEC]: Add ICMP host
relookup support) introduced some dst leaks on error paths: the rt
pointer can be forgotten to be put. Fix it bu going to a proper label.

Found after net namespace's lo refused to unregister :) Many thanks to
Den for valuable help during debugging.

Herbert pointed out, that xfrm_lookup() will put the rtable in case
of error itself, so the first goto fix is redundant.

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Signed-off-by: Denis V. Lunev <den@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/icmp.c