]> err.no Git - linux-2.6/commit
[IPV4]: ipconfig.c: fix dhcp timeout behaviour
authorMaxime Bizon <mbizon@freebox.fr>
Tue, 28 Jun 2005 20:21:12 +0000 (13:21 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 28 Jun 2005 20:21:12 +0000 (13:21 -0700)
commit7a1af5d7bb94af16b980a53330436b9fadc12435
tree30f61b21c9e80d22f59f76bc1224a42e6fc0fa4a
parent2c2910a401f1ce2ac9136171e7522e731e1a2a8c
[IPV4]: ipconfig.c: fix dhcp timeout behaviour

I think there is a small bug in ipconfig.c in case IPCONFIG_DHCP is set
and dhcp is used.

When a DHCPOFFER is received, ip address is kept until we get DHCPACK.
If no ack is received, ic_dynamic() returns negatively, but leaves the
offered ip address in ic_myaddr.

This makes the main loop in ip_auto_config() break and uses the maybe
incomplete configuration.

Not sure if it's the best way to do, but the following trivial patch
correct this.

Signed-off-by: Maxime Bizon <mbizon@freebox.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/ipconfig.c