]> err.no Git - linux-2.6/commit
[SCSI] SCSI core: fix leakage of scsi_cmnd's
authorJames Bottomley <James.Bottomley@steeleye.com>
Fri, 9 Sep 2005 18:40:23 +0000 (13:40 -0500)
committerJames Bottomley <jejb@mulgrave.(none)>
Fri, 9 Sep 2005 21:30:59 +0000 (16:30 -0500)
commit788ce43aa1ad7158f894b6bb3df8ba2f63794c20
tree56b84ceff12e0296f782023563a7a612a34fa6d9
parente91442b635be776ea205fba233bdd5bc74b62bc3
[SCSI] SCSI core: fix leakage of scsi_cmnd's

Actually, just one problem and one cosmetic fix:

1) We need to dequeue for the loop and kill case (it seems easiest
simply to dequeue in the scsi_kill_request() routine)
2) There's no real need to drop the queue lock.  __scsi_done() is lock
agnostic, so since there's no requirement, let's just leave it in to
avoid any locking issues.

Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
drivers/scsi/scsi_lib.c