]> err.no Git - linux-2.6/commit
V4L/DVB (5678): Zr364xx: fix return values
authorAkinobu Mita <akinobu.mita@gmail.com>
Sun, 20 May 2007 12:12:10 +0000 (09:12 -0300)
committerMauro Carvalho Chehab <mchehab@infradead.org>
Wed, 18 Jul 2007 17:23:33 +0000 (14:23 -0300)
commit783aa8fa1fe666a039edb784d9458647da97d28a
tree0542723302160dbd4b666b40ad08cc256b119519
parent1b9d313c38291c6d60f1fbf6a2bc62c484fdaa21
V4L/DVB (5678): Zr364xx: fix return values

This patch fixes several return value related problems in zr364xx.

- return -ENOMEM instead of -ENODEV on out of memory

- zr364xx checks video_register_device() error only when
  its return value is -1. But video_register_device() doesn't
  always return -1 on error.

- If usb_register() returns error, module_init() wrongly returns 1:
retval = usb_register(&zr364xx_driver) < 0;
...
return retval;

  And it allows the module to be loaded. Because sys_init_module() doesn't
  see positive return value as error.

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: Antoine Jacquet <royale@zerezo.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
drivers/media/video/zr364xx.c