]> err.no Git - linux-2.6/commit
[PATCH] rcu: Fix sign bug making rcu_random always return the same sequence
authorJosh Triplett <josht@us.ibm.com>
Wed, 4 Oct 2006 09:17:12 +0000 (02:17 -0700)
committerLinus Torvalds <torvalds@g5.osdl.org>
Wed, 4 Oct 2006 14:55:31 +0000 (07:55 -0700)
commit75cfef32f26d03f5d0a0833572d52f94ad858a36
tree2440ee021888c4d743cf403a75d859060127479b
parent2860aaba4dc87fa43c08724434b87a8650f3bff5
[PATCH] rcu: Fix sign bug making rcu_random always return the same sequence

rcu_random uses a counter rrs_count to occasionally mix data from
get_random_bytes into the state of its pseudorandom generator.  However,
the rrs_counter gets declared as an unsigned long, and rcu_random checks
for --rrs_count < 0, so this code will never mix any real random data into
the state, and will thus always return the same sequence of random numbers.

Also, change the return value of rcu_random from long to unsigned long, to
avoid potential issues caused by the use of the % operator, which can
return negative values for negative left operands.

Signed-off-by: Josh Triplett <josh@freedesktop.org>
Acked-by: Paul E. McKenney <paulmck@us.ibm.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
kernel/rcutorture.c