]> err.no Git - linux-2.6/commit
[SCTP]: Add check for hmac_algo parameter in sctp_verify_param()
authorWei Yongjun <yjwei@cn.fujitsu.com>
Sun, 13 Apr 2008 01:39:19 +0000 (18:39 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sun, 13 Apr 2008 01:39:19 +0000 (18:39 -0700)
commit72da7b3860cabf427590b4982bc880bafab4d5c8
tree7a5084f9eac6c5556d792d0503158860b046201f
parente56cfad132f2ae269082359d279c17230c987e74
[SCTP]: Add check for hmac_algo parameter in sctp_verify_param()

RFC 4890 has the following text:

  The HMAC algorithm based on SHA-1 MUST be supported and
  included in the HMAC-ALGO parameter.

As a result, we need to check in sctp_verify_param() that HMAC_SHA1 is
present in the list.  If not, we should probably treat this as a
protocol violation.

It should also be a protocol violation if the HMAC parameter is empty.

Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sctp/sm_make_chunk.c