]> err.no Git - linux-2.6/commit
VT_WAITACTIVE: Avoid returning EINTR when not necessary
authorLinus Torvalds <torvalds@woody.linux-foundation.org>
Sun, 7 Oct 2007 23:02:55 +0000 (16:02 -0700)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Sun, 7 Oct 2007 23:02:55 +0000 (16:02 -0700)
commit70cb97935b8859f27296772885104b599f560576
tree089c5c2098888492c8d54c2d0c52772a64db8423
parentfc8b28a65d81a6fdf58ef81ce5b8ac7a35304e68
VT_WAITACTIVE: Avoid returning EINTR when not necessary

We should generally prefer to return ERESTARTNOHAND rather than EINTR,
so that processes with unhandled signals that get ignored don't return
EINTR.

This can help with X startup issues:

    Fatal server error:
    xf86OpenConsole: VT_WAITACTIVE failed: Interrupted system call

although the real fix is having the X server always retry EINTR
regardless (since EINTR does happen for signals that have handlers
installed). Keithp has a patch for that.

Regardless, ERESTARTNOHAND is the correct thing to use.

Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/char/vt_ioctl.c