]> err.no Git - linux-2.6/commit
[PATCH] x86-64: Only look at per_cpu data for online cpus.
authorEric W. Biederman <ebiederm@xmission.com>
Tue, 24 Oct 2006 23:00:23 +0000 (01:00 +0200)
committerAndi Kleen <andi@one.(none)>
Tue, 24 Oct 2006 23:00:23 +0000 (01:00 +0200)
commit70a0a5357db20c291d46c04011d646d5d84c868c
treefb82087c685b2f3018172a5956f86cc36fc833d1
parentd1752aa884ec0ac3027c1a3d456bf69bf765c8b8
[PATCH] x86-64: Only look at per_cpu data for online cpus.

When I generalized __assign_irq_vector I failed to pay attention
to what happens when you access a per cpu data structure for
a cpu that is not online.   It is an undefined case making any
code that does it have undefined behavior as well.

The code still needs to be able to allocate a vector across cpus
that are not online to properly handle combinations like lowest
priority interrupt delivery and cpu_hotplug.  Not that we can do
that today but the infrastructure shouldn't prevent it.

So this patch updates the places where we touch per cpu data
to only touch online cpus, it makes cpu vector allocation
an atomic operation with respect to cpu hotplug, and it updates
the cpu start code to properly initialize vector_irq so we
don't have inconsistencies.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Andi Kleen <ak@suse.de>
arch/x86_64/kernel/io_apic.c
arch/x86_64/kernel/smpboot.c
include/asm-x86_64/hw_irq.h