]> err.no Git - linux-2.6/commit
[SCSI] Get rid of scsi_cmnd->done
authorMatthew Wilcox <matthew@wil.cx>
Tue, 25 Sep 2007 16:42:04 +0000 (12:42 -0400)
committerJames Bottomley <jejb@mulgrave.localdomain>
Fri, 12 Oct 2007 18:52:46 +0000 (14:52 -0400)
commit6f5391c283d7fdcf24bf40786ea79061919d1e1d
tree32ee9abddf9879445792019e1c03bcd28ce6bd4f
parent687d2bc4877081a44c41b5b312e012cc69edda53
[SCSI] Get rid of scsi_cmnd->done

The ULD ->done callback moves into the scsi_driver.  By moving the call
to scsi_io_completion() from scsi_blk_pc_done() to scsi_finish_command(),
we can eliminate the latter entirely.  By returning 'good_bytes' from
the ->done callback (rather than invoking scsi_io_completion()), we can
stop exporting scsi_io_completion().

Also move the prototypes from sd.h to sd.c as they're all internal anyway.
Rename sd_rw_intr to sd_done and rw_intr to sr_done.

Inspired-by: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
drivers/scsi/scsi.c
drivers/scsi/scsi_error.c
drivers/scsi/scsi_lib.c
drivers/scsi/scsi_priv.h
drivers/scsi/sd.c
drivers/scsi/sr.c
include/scsi/scsi_cmnd.h
include/scsi/scsi_driver.h
include/scsi/sd.h