]> err.no Git - linux-2.6/commit
skge napi->poll() locking bug
authorMarin Mitov <mitov@issp.bas.bg>
Sun, 23 Mar 2008 08:20:09 +0000 (10:20 +0200)
committerJeff Garzik <jeff@garzik.org>
Wed, 26 Mar 2008 03:42:06 +0000 (23:42 -0400)
commit6ef2977d414cc196baba0fb53509c5f8cd9154b4
tree5cff016cfe15fcf79c169d6fa105093ee8972539
parent9f5e60dd5ffca938da4cabc197af8b9405b5512e
skge napi->poll() locking bug

According to: Documentation/networking/netdevices.txt:

<cite>
napi->poll:
..........
Context: softirq
         will be called with interrupts disabled by netconsole.
</cite>

napi->poll() could be called either with interrupts enabled
(in softirq context) or disabled (by netconsole), so the irq flag
should be preserved.

Inspired by Ingo's resent forcedeth patch :-)

Signed-off-by: Marin Mitov <mitov@issp.bas.bg>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/net/skge.c