]> err.no Git - linux-2.6/commit
[PATCH] savagefb: X-panning fixes
authorAntonino A. Daplas <adaplas@gmail.com>
Wed, 9 Nov 2005 05:39:05 +0000 (21:39 -0800)
committerLinus Torvalds <torvalds@g5.osdl.org>
Wed, 9 Nov 2005 15:56:34 +0000 (07:56 -0800)
commit6d83b0bb8e5efda28ce4a1abc78277f1d03e50e5
tree9fbf5337bb2428f94dcf428b3387f3198b56ad28
parent64c7c8f88559624abdbe12b5da6502e8879f8d28
[PATCH] savagefb: X-panning fixes

The driver unconditionally sets xpanstep to 2.  However, a value of 4
empirically works better at bpp = 8, and 2 for 16 and 32.  This buglet was
exposed by the rotation code.

Second fix is the unconditional call to update_start() without verifying if
the offsets are correct.  Remove this call, it's not necessary and secondly,
it causes a crash with invalid values.

Signed-off-by: Antonino Daplas <adaplas@pol.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/video/savage/savagefb_driver.c