]> err.no Git - linux-2.6/commit
[PATCH] libertas: remove a hundred CMD_RET_xxx definitions
authorHolger Schurig <hs4233@mail.mn-solutions.de>
Thu, 2 Aug 2007 15:53:36 +0000 (11:53 -0400)
committerDavid S. Miller <davem@sunset.davemloft.net>
Wed, 10 Oct 2007 23:49:53 +0000 (16:49 -0700)
commit6b63cd0f420c3c3002024da6c9eff252a3772021
tree87df4e20432a393b9137952a4ad6aa0cc63163b5
parentece561919326236c7fb791a5e883f0eb76af029e
[PATCH] libertas: remove a hundred CMD_RET_xxx definitions

types.h contains the same amount of CMD_RET_xxx and CMD_xxx definitions.
They contains the same info: the firmware command opcode and, when the
firmware sends back a result, the command opcode ORed with 0x8000.

Having the same data twice in the source code is redundant and can lead to
errors (e.g. if you update or delete only one instance). This patch removed
all CMD_RET_xxx definitions and introduces a simple CMD_RET() macro.

Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/libertas/cmdresp.c
drivers/net/wireless/libertas/debugfs.c
drivers/net/wireless/libertas/host.h
drivers/net/wireless/libertas/join.c