]> err.no Git - linux-2.6/commit
cyclone.c: silly use of volatile, __iomem fixes
authorAl Viro <viro@ftp.linux.org.uk>
Thu, 26 Jul 2007 16:34:59 +0000 (17:34 +0100)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Thu, 26 Jul 2007 18:11:57 +0000 (11:11 -0700)
commit6aa8b04975e71fb3d67bec7fbe2995b9bf54a06e
tree2eb8233f350766a3582d5a3dfcf87c3590f44c81
parent712aaa1cb1c0a83e5ffb5376e1d7ee3dd539f4e4
cyclone.c: silly use of volatile, __iomem fixes

u32* volatile cyclone_timer means volatile auto pointer to u32,
which is clearly not what had been intended (we never even take
the address of that variable, let alone pass it to something that
could change it behind our back).  u32 volatile * is what the
authors apparently wanted to say, but in reality we don't need that
qualifier there at all - it's (properly) only passed to iomem helpers
which takes care of that stuff just fine.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
arch/ia64/kernel/cyclone.c