]> err.no Git - linux-2.6/commit
[PATCH] coverity: tty_ldisc_ref return null check
authorKAMBAROV, ZAUR <kambarov@berkeley.edu>
Wed, 29 Jun 2005 03:45:12 +0000 (20:45 -0700)
committerLinus Torvalds <torvalds@ppc970.osdl.org>
Wed, 29 Jun 2005 04:20:34 +0000 (21:20 -0700)
commit69f63c5c34d0b34ee2cbf10c5ff7fcff0404879e
tree1023d240c44cc2a137c9cca4b6c015e584e30356
parentc7f1721ef284c6e8257c7471a02148db76105036
[PATCH] coverity: tty_ldisc_ref return null check

We add a check of the return value of tty_ldisc_ref(), which
is checked 7 out of 8 times, e.g.:

149   ld = tty_ldisc_ref(tty);
150   if (ld != NULL) {
151   if (ld->set_termios)
152   (ld->set_termios)(tty, &old_termios);
153   tty_ldisc_deref(ld);
154   }

This defect was found automatically by Coverity Prevent, a static analysis
tool.

(akpm: presumably `ld' is never NULL.  Oh well)

Signed-off-by: Zaur Kambarov <zkambarov@coverity.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/char/tty_ioctl.c