]> err.no Git - linux-2.6/commit
spi_mpc83xx.c underclocking hotfix
authorClifford Wolf <clifford@clifford.at>
Tue, 17 Jul 2007 11:04:06 +0000 (04:04 -0700)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Tue, 17 Jul 2007 17:23:04 +0000 (10:23 -0700)
commit698ca47e8dba93f4b001b06b4c7037b09ac6eb09
tree2e1f817e847d37b7397171d7fe15dc5ee0a79d07
parent78961a5740374a8143f8fe120300f2ed160dd276
spi_mpc83xx.c underclocking hotfix

The MPC83xx SPI controller clock divider can divide the system clock by not
more then 1024.  The spi_mpc83xx driver does not check this and silently
writes garbage to the SPI controller registers when asked to run at lower
frequencies.  I've tried to run the SPI on a 266MHz MPC8349E with 100kHz
for debugging a bus problem and suddenly was confronted with a 2nd problem
to debug..  ;-)

The patch adds an additional check which avoids writing garbage to the SPI
controller registers and warn the user about it.  This might help others to
avoid simmilar problems.

Cc: Kumar Gala <galak@gate.crashing.org>
Cc: David Brownell <david-b@pacbell.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/spi/spi_mpc83xx.c