]> err.no Git - linux-2.6/commit
IB/ipath: Fix crash on unload introduced by sysfs changes
authorRoland Dreier <rolandd@cisco.com>
Fri, 25 Jan 2008 22:15:21 +0000 (14:15 -0800)
committerRoland Dreier <rolandd@cisco.com>
Fri, 25 Jan 2008 22:15:21 +0000 (14:15 -0800)
commit657c2f2cbccbac88689ac5174fc13dd3f9aece34
treecdb292c2da582d49a3908244914dd192535e76cd
parentb47711bfbcd4eb77ca61ef0162487b20e023ae55
IB/ipath: Fix crash on unload introduced by sysfs changes

Commit 23b9c1ab ("Infiniband: make ipath driver use default driver
groups.") introduced a bug in the ipath driver where
ipath_device_create_group() fell through into the error path, even on
success, which meant that the sysfs groups it created would always get
removed right away.  This made ipath_device_remove_group() hit the
BUG_ON() in sysfs_remove_group() when it tried to remove those groups a
second time.

Correct the return path so that the groups stick around until they are
supposed to be cleaned up.

Signed-off-by: Roland Dreier <rolandd@cisco.com>
drivers/infiniband/hw/ipath/ipath_sysfs.c