]> err.no Git - linux-2.6/commit
[NET]: Fix race condition in sk_stream_wait_connect
authorHerbert Xu <herbert@gondor.apana.org.au>
Thu, 3 Nov 2005 22:56:56 +0000 (09:56 +1100)
committerArnaldo Carvalho de Melo <acme@mandriva.com>
Sat, 5 Nov 2005 23:05:20 +0000 (21:05 -0200)
commit6151b31c9616d71f714fc7ef8e2306f67f3b94c3
tree59ac0ad477d80c53bbf173b5fc863ab239f0705c
parenteb229c4cdc3389682cda20adb015ba767950a220
[NET]: Fix race condition in sk_stream_wait_connect

When sk_stream_wait_connect detects a state transition to ESTABLISHED
or CLOSE_WAIT prior to it going to sleep, it will return without
calling finish_wait and decrementing sk_write_pending.

This may result in crashes and other unintended behaviour.

The fix is to always call finish_wait and update sk_write_pending since
it is safe to do so even if the wait entry is no longer on the queue.

This bug was tracked down with the help of Alex Sidorenko and the
fix is also based on his suggestion.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
net/core/stream.c