]> err.no Git - linux-2.6/commit
[PATCH] copy_process: cosmetic ->ioprio tweak
authorOleg Nesterov <oleg@tv-sign.ru>
Fri, 29 Sep 2006 09:00:52 +0000 (02:00 -0700)
committerLinus Torvalds <torvalds@g5.osdl.org>
Fri, 29 Sep 2006 16:18:18 +0000 (09:18 -0700)
commit5b160f5ecd2f1b6df2e0015dc1f319c8ef803d62
treeff7f77b4178299146d6450f01f5d1da769c3fda9
parent1c573afebc6213e4372e0d8352034c23d5262e1f
[PATCH] copy_process: cosmetic ->ioprio tweak

copy_process:
// holds tasklist_lock + ->siglock
       /*
        * inherit ioprio
        */
       p->ioprio = current->ioprio;

Why?  ->ioprio was already copied in dup_task_struct().  I guess this is
needed to ensure that the child can't escape
sys_ioprio_set(IOPRIO_WHO_{PGRP,USER}), yes?

In that case we don't need ->siglock held, and the comment should be
updated.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Jens Axboe <axboe@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
kernel/fork.c