]> err.no Git - linux-2.6/commit
[PATCH] proc: optimize proc_check_dentry_visible
authorEric W. Biederman <ebiederm@xmission.com>
Mon, 26 Jun 2006 07:25:57 +0000 (00:25 -0700)
committerLinus Torvalds <torvalds@g5.osdl.org>
Mon, 26 Jun 2006 16:58:26 +0000 (09:58 -0700)
commit5b0c1dd38b66e2dd0cf655aa845e341b50b93ddd
treee8d3341591958d9c3e11400a2f16287a6dd00c46
parent13b41b09491e5d75e8027dca1ee78f5e073bc4c0
[PATCH] proc: optimize proc_check_dentry_visible

The code doesn't need to sleep to when making this check so I can just do the
comparison and not worry about the reference counts.

TODO: While looking at this I realized that my original cleanup did not push
the permission check far enough down into the stack.  The call of
proc_check_dentry_visible needs to move out of the generic proc
readlink/follow link code and into the individual get_link instances.
Otherwise the shared resources checks are not quite correct (shared
files_struct does not require a shared fs_struct), and there are races with
unshare.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
fs/proc/base.c