]> err.no Git - systemd/commit
projects / systemd / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: a60b077) | patch
cdrom_id: Do not ignore errors from scsi_cmd_run()
authorMartin Pitt <martin.pitt@ubuntu.com>
Thu, 15 Apr 2010 06:56:48 +0000 (08:56 +0200)
committerMartin Pitt <martin.pitt@ubuntu.com>
Thu, 15 Apr 2010 19:29:17 +0000 (21:29 +0200)
commit58e178894bfc040834e1270c6fe9b9fdef513550
tree8e1a7b5308a2f2c04157bc89468a3a874b7954catree | snapshot
parenta60b077a465b19af2efd9bf0cb5f0f67117be780commit | diff
cdrom_id: Do not ignore errors from scsi_cmd_run()

scsi_cmd_run() can return positive error messages if we have CHECK_CONDITION
set and get the error code from the SCSI command result. So check the result
for non-zero, not for being negative.

This should fix another cause for "phantom" media in empty CD-ROM drives.

Thanks to Mike Brudevold <mike@brudevold.com> for spotting this!

https://launchpad.net/bugs/562978
extras/cdrom_id/cdrom_id.c diff | blob | history
systemd, git://git.err.no/systemd