]> err.no Git - linux-2.6/commit
[PATCH] noop-iosched: avoid corrupted request merging
authorJens Axboe <axboe@suse.de>
Mon, 31 Oct 2005 08:23:54 +0000 (09:23 +0100)
committerLinus Torvalds <torvalds@g5.osdl.org>
Mon, 31 Oct 2005 15:46:28 +0000 (07:46 -0800)
commit581c1b14394aee60aff46ea67d05483261ed6527
tree6b269000a4b5bbcdc0edcfdf615851c9de0d412a
parent4fc207419d95e0e16fdc78e2f48f7c0b3640ffe5
[PATCH] noop-iosched: avoid corrupted request merging

Tejun Heo notes:

   "I'm currently debugging this.  The problem is that we are using the
    generic dispatch queue directly in the noop sched and merging is NOT
    allowed on dispatch queues but generic handling of last_merge tries
    to merge requests.  I'm still trying to verify this, so I'll be back
    with results soon."

In the meantime, disable merging for noop by setting REQ_NOMERGE in
elevator_noop_add_request().

Eventually, we should add a noop_list and do the dispatching like in the
other io schedulers.  Merging is still beneficial for noop (and it has
always done it).

Signed-off-by: Jens Axboe <axboe@suse.de>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/block/noop-iosched.c