]> err.no Git - linux-2.6/commit
[UM]: Fix use of skb after netif_rx
authorJulia Lawall <julia@diku.dk>
Tue, 11 Dec 2007 01:14:46 +0000 (17:14 -0800)
committerDavid S. Miller <davem@sunset.davemloft.net>
Tue, 11 Dec 2007 10:45:27 +0000 (02:45 -0800)
commit505a41d43c24345f3fa77ddab152d1f82dd8264d
treef7d30d04faa899cf0ac3a36f29e0b3b1227837c2
parent95a02cfd4d33886c166d4a5f309120f8d32ced58
[UM]: Fix use of skb after netif_rx

Recently, Wang Chen submitted a patch
(d30f53aeb31d453a5230f526bea592af07944564) to move a call to netif_rx(skb)
after a subsequent reference to skb, because netif_rx may call kfree_skb on
its argument.  The same problem occurs in some other drivers as well.

This was found using the following semantic match.
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
expression skb, e,e1;
@@

(
 netif_rx(skb);
|
 netif_rx_ni(skb);
)
  ... when != skb = e
(
  skb = e1
|
* skb
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
arch/um/drivers/net_kern.c