]> err.no Git - linux-2.6/commit
[PATCH] slab: don't BUG on duplicated cache
authorAndrew Morton <akpm@osdl.org>
Mon, 7 Nov 2005 08:58:00 +0000 (00:58 -0800)
committerLinus Torvalds <torvalds@g5.osdl.org>
Mon, 7 Nov 2005 15:53:24 +0000 (07:53 -0800)
commit4f12bb4f7715f418a9c80f89447948790f476958
treef08c7e26b19687d26b29082e50101daf2e5a4b75
parent7fd93cf30c531fd8b014e827e7a85fcfc010b2c6
[PATCH] slab: don't BUG on duplicated cache

slab presently goes BUG if someone tries to register an already-registered
cache.

But this can happen if the user accidentally loads a module which is already
statically linked into the kernel.  Nuking the kernel is rather a harsh
reaction.

Change it into a warning, and just fail the kmem_cache_alloc() attempt.  If
the module is well-behaved, the modprobe will fail and all is well.

Notes:

- Swaps the ranking of cache_chain_sem and lock_cpu_hotplug().  Doesn't seem
  important.

Acked-by: Manfred Spraul <manfred@colorfullife.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
mm/slab.c