]> err.no Git - linux-2.6/commit
[PATCH] setup_boot_APIC_clock() irq-enable fix
authorIngo Molnar <mingo@elte.hu>
Thu, 22 Mar 2007 09:31:19 +0000 (10:31 +0100)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Fri, 23 Mar 2007 02:42:31 +0000 (19:42 -0700)
commit4edc5db83f574dfcc8be35b7b96760ded543b360
tree73130848bbb4706699b70621ee2b4d587830cedf
parent9c35dd7f8bda1849dcb430be99325504221048df
[PATCH] setup_boot_APIC_clock() irq-enable fix

latest -git triggers an irqtrace/lockdep warning of a leaked
irqs-off condition:

  BUG: at kernel/fork.c:1033 copy_process()

after some debugging it turns out that commit ca1b940c accidentally left
interrupts disabled - which trickled down all the way to the first time
we fork a kernel thread and triggered the warning.

the fix is to re-enable interrupts in the 'else' branch of
setup_boot_APIC_clock()'s pmtimers calibration path.

Reported-by: Michal Piotrowski <michal.k.k.piotrowski@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Acked-by: Thomas Gleixner <tglx@brown.paperbag.linutronix.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
arch/i386/kernel/apic.c