]> err.no Git - linux-2.6/commit
[PATCH] buglet in radix_tree_tag_set
authorPeter Zijlstra <a.p.zijlstra@chello.nl>
Fri, 23 Jun 2006 09:03:25 +0000 (02:03 -0700)
committerLinus Torvalds <torvalds@g5.osdl.org>
Fri, 23 Jun 2006 14:42:49 +0000 (07:42 -0700)
commit4c91c3648c620003cb7b21b8858f36cd6132e168
tree6572fedb9a18ba0b31695f1ba30a219621b6f20a
parent58ce1fd5805647a58a050bbbbd2252ea5ecb47b3
[PATCH] buglet in radix_tree_tag_set

The comment states: 'Setting a tag on a not-present item is a BUG.' Hence
if 'index' is larger than the maxindex; the item _cannot_ be presen; it
should also be a BUG.

Also, this allows the following statement (assume a fresh tree):

  radix_tree_tag_set(root, 16, 1);

to fail silently, but when preceded by:

  radix_tree_insert(root, 32, item);

it would BUG, because the height has been extended by the insert.

In neither case was 16 present.

Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Acked-by: Nick Piggin <npiggin@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
lib/radix-tree.c