]> err.no Git - linux-2.6/commit
projects / linux-2.6 / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 8d08aed) | patch
[IA64] Fix bug in ia64 specific down() function
authorZoltan Menyhart <Zoltan.Menyhart@bull.net>
Fri, 13 Jan 2006 16:25:23 +0000 (17:25 +0100)
committerTony Luck <tony.luck@intel.com>
Tue, 17 Jan 2006 22:04:00 +0000 (14:04 -0800)
commit4b16bfbf8f8013fefb49592d030ff87651ab48cb
treece9150f8ceac6150261f5bc69afdf9d2e95def19tree | snapshot
parent8d08aed8d7714683b33666cc066e20f957dda01dcommit | diff
[IA64] Fix bug in ia64 specific down() function

Chen, Kenneth W wrote:
> The memory order semantics for include/asm-ia64/semaphore.h:down()
> doesn't look right.  It is using atomic_dec_return, which eventually
> translate into ia64_fetch_and_add() that uses release semantics.
> Shouldn't it use acquire semantics?

Use ia64_fetchadd() instead of atomic_dec_return()

Acked-by: Ken Chen <kenneth.w.chen@intel.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
include/asm-ia64/semaphore.h diff | blob | history
Linux 2.6 source tree