]> err.no Git - linux-2.6/commit
[PATCH] Fix race in efi variable delete code
authorMatt Domsch <Matt_Domsch@dell.com>
Fri, 26 Jan 2007 08:57:18 +0000 (00:57 -0800)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Fri, 26 Jan 2007 21:51:01 +0000 (13:51 -0800)
commit496a0fc8c5572a626de41d56d7c7ed005a2c1b48
tree28039f07573e7f935d1e7b9e3a9aa5354b91d233
parent01f2073411e01777e3c6f45a4bf05ea76493f326
[PATCH] Fix race in efi variable delete code

Fix race when deleting an EFI variable and issuing another EFI command on
the same variable.  The removal of the variable from the efivars_list
should be done in efivar_delete and not delayed until the kobject release.

Furthermore, remove the item from the list at module unload time, and use
list_for_each_entry_safe() rather than list_for_each_safe() for
readability.

Tested on ia64.

Signed-off-by: Prarit Bhargava <prarit@redhat.com>
Signed-off-by: Matt Domsch <Matt_Domsch@dell.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/firmware/efivars.c