]> err.no Git - linux-2.6/commit
NLM: Fix sign of length of NLM variable length strings
authorChuck Lever <chuck.lever@oracle.com>
Thu, 1 Nov 2007 20:56:53 +0000 (16:56 -0400)
committerJ. Bruce Fields <bfields@citi.umich.edu>
Fri, 1 Feb 2008 21:42:02 +0000 (16:42 -0500)
commit48df020aa17ac95a012ff765b0086ede5996b320
tree52aa9d1ff1e320ead499bddfe98cb05b06df1311
parente5cff482c78a35b9f149a06aa777a1bd693864fb
NLM: Fix sign of length of NLM variable length strings

According to The Open Group's NLM specification, NLM callers are variable
length strings.  XDR variable length strings use an unsigned 32 bit length.
And internally, negative string lengths are not meaningful for the Linux
NLM implementation.

Clean up: Make nlm_lock.len and nlm_reboot.len unsigned integers.  This
makes the sign of NLM string lengths consistent with the sign of xdr_netobj
lengths.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Acked-By: NeilBrown <neilb@suse.de>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
fs/lockd/host.c
include/linux/lockd/lockd.h
include/linux/lockd/xdr.h