]> err.no Git - linux-2.6/commit
x86: make "apic" an early_param() on 32-bit, NULL check
authorRene Herman <rene.herman@keyaccess.nl>
Mon, 11 Aug 2008 17:20:17 +0000 (19:20 +0200)
committerIngo Molnar <mingo@elte.hu>
Mon, 11 Aug 2008 17:40:38 +0000 (19:40 +0200)
commit48d97cb65e62a5f1122ac2cf1149800d4f4693e8
tree20f9ccaeeb89eebec0444fb3eb45ebaa6f2c3525
parentb0fbaa6b5976962434349849673b9ff63631b6d4
x86: make "apic" an early_param() on 32-bit, NULL check

Cyrill Gorcunov observed:

> you turned it into early_param so now it's NULL injecting vulnerabled.
> Could you please add checking for NULL str param?

fix that.

Also, change the name of 'str' into 'arg', to make it more apparent
that this is an optional argument that can be NULL, not a string
parameter that is empty when unset.

Reported-by: Cyrill Gorcunov <gorcunov@gmail.com>
Signed-off-by: Rene Herman <rene.herman@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
arch/x86/kernel/apic_32.c