]> err.no Git - linux-2.6/commit
[SCSI] tmscsim: remove bogus endianness conversions
authorGuennadi Liakhovetski <g.liakhovetski@gmx.de>
Fri, 4 May 2007 20:59:40 +0000 (22:59 +0200)
committerJames Bottomley <jejb@mulgrave.il.steeleye.com>
Sun, 6 May 2007 14:33:21 +0000 (09:33 -0500)
commit46e5ba2b644d1c7be1253ec32e7cd6ab1dcdf790
tree2004e75a362b31fd710c57153337995484a5a1c4
parent860bfecf71495fc2b82c878958c97b0b6b601626
[SCSI] tmscsim: remove bogus endianness conversions

cpu_to_le32 endianness conversions in tmscsim.c, followed by
arithmetic operations don't look correct. Besides, {in,out}[wl]
already perform the necessary conversions. Further, bus addresses
of request buffers are guaranteed to be (mapped) under 4G by
current scsi- and block-layer defaults. This could be explicitly
enforced by using blk_queue_bounce_limit(), which, however,
doesn't seem to be the common practice among SCSI drivers.

Signed-off-by: G. Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
drivers/scsi/tmscsim.c
drivers/scsi/tmscsim.h