]> err.no Git - linux-2.6/commit
libata: move link onlineness check out of softreset methods
authorTejun Heo <htejun@gmail.com>
Mon, 7 Apr 2008 16:46:56 +0000 (01:46 +0900)
committerJeff Garzik <jgarzik@redhat.com>
Thu, 17 Apr 2008 19:44:25 +0000 (15:44 -0400)
commit45db2f6c95eee7c6622ea1b3edb9abafba58e3ab
tree1c57efcf3e118b177dd7c9c1070b8af70694aff3
parent2a0c15ca39f5881aa1b472ca856bb7a2e584ece7
libata: move link onlineness check out of softreset methods

Currently, SATA softresets should do link onlineness check before
actually performing SRST protocol but it doesn't really belong to
softreset.

This patch moves onlineness check in softreset to ata_eh_reset() and
ata_eh_followup_srst_needed() to clean up code and help future sata_mv
changes which need clear separation between SCR and TF accesses.

sata_fsl is peculiar in that its softreset really isn't softreset but
combination of hardreset and softreset.  This patch adds dummy private
->prereset to keep the current behavior but the driver really should
implement separate hard and soft resets and return -EAGAIN from
hardreset if it should be follwed by softreset.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
drivers/ata/ahci.c
drivers/ata/libata-core.c
drivers/ata/libata-eh.c
drivers/ata/libata-sff.c
drivers/ata/pata_bf54x.c
drivers/ata/pata_scc.c
drivers/ata/sata_fsl.c
drivers/ata/sata_sil24.c