]> err.no Git - linux-2.6/commit
libata: s/ap->id/ap->print_id/g
authorTejun Heo <htejun@gmail.com>
Tue, 20 Feb 2007 16:06:51 +0000 (01:06 +0900)
committerJeff Garzik <jeff@garzik.org>
Wed, 21 Feb 2007 09:58:20 +0000 (04:58 -0500)
commit44877b4e22f391d39c6589412106a3668e81a05b
tree10bf134c2c8c15e3504d67461b42f53c6de88523
parent5ce0cf6fafd02fb4c43fc1a1bee6069d6c0a36b1
libata: s/ap->id/ap->print_id/g

ata_port has two different id fields - id and port_no.  id is
system-wide 1-based unique id for the port while port_no is 0-based
host-wide port number.  The former is primarily used to identify the
ATA port to the user in printk messages while the latter is used in
various places in libata core and LLDs to index the port inside the
host.

The two fields feel quite similar and sometimes ap->id is used in
place of ap->port_no, which is very difficult to spot.  This patch
renames ap->id to ap->print_id to reduce the possibility of such bugs.

Some printk messages are adjusted such that id string (ata%u[.%u])
isn't printed twice and/or to use ata_*_printk() instead of hardcoded
id format.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/ata/libata-core.c
drivers/ata/libata-eh.c
drivers/ata/libata-scsi.c
drivers/ata/libata-sff.c
drivers/ata/pata_sis.c
drivers/ata/pdc_adma.c
drivers/ata/sata_mv.c
drivers/ata/sata_qstor.c
drivers/ata/sata_sx4.c
include/linux/libata.h