]> err.no Git - linux-2.6/commit
jbd: correctly unescape journal data blocks
authorDuane Griffin <duaneg@dghda.com>
Thu, 20 Mar 2008 00:00:53 +0000 (17:00 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 20 Mar 2008 01:53:36 +0000 (18:53 -0700)
commit439aeec639d7c57f3561054a6d315c40fd24bb74
tree92ccf27e7fe0ae99dfc8e3bcd0ef4fe7d1e0795a
parent44e0451db0a9c0bceabaa9cc77cbcc717a094fcc
jbd: correctly unescape journal data blocks

Fix a long-standing typo (predating git) that will cause data corruption if a
journal data block needs unescaping.  At the moment the wrong buffer head's
data is being unescaped.

To test this case mount a filesystem with data=journal, start creating and
deleting a bunch of files containing only JFS_MAGIC_NUMBER (0xc03b3998), then
pull the plug on the device.  Without this patch the files will contain zeros
instead of the correct data after recovery.

Signed-off-by: Duane Griffin <duaneg@dghda.com>
Acked-by: Jan Kara <jack@suse.cz>
Cc: <linux-ext4@vger.kernel.org>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/jbd/recovery.c