]> err.no Git - linux-2.6/commit
sysfs: make sysfs_add/remove_one() call link/unlink_sibling() implictly
authorTejun Heo <htejun@gmail.com>
Thu, 2 Aug 2007 12:38:03 +0000 (21:38 +0900)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 12 Oct 2007 21:51:03 +0000 (14:51 -0700)
commit41fc1c27452e041a18e5141b8203ee0ea72bc483
treefc81138ca37182c25931818681630c90b018b127
parentff869de7bf5e76adffebd3a176c1c73bca7eddb7
sysfs: make sysfs_add/remove_one() call link/unlink_sibling() implictly

When adding or removing a sysfs_dirent, the user used to be required
to call link/unlink separately.  It was for two reasons - code looked
like that before sysfs_addrm_cxt conversion and to avoid looping
through parent_sd->children list twice during removal.

Performance optimization during removal just isn't worth it.  Make
sysfs_add/remove_one() call sysfs_link/unlink_sibing() implicitly.
This makes code simpler albeit slightly less efficient.  This change
doesn't introduce any noticeable behavior change.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
fs/sysfs/dir.c
fs/sysfs/file.c
fs/sysfs/inode.c
fs/sysfs/symlink.c
fs/sysfs/sysfs.h