]> err.no Git - linux-2.6/commit
[PATCH] Use decimal for PTRACE_ATTACH and PTRACE_DETACH.
authorRoland McGrath <roland@redhat.com>
Fri, 29 Sep 2006 09:00:45 +0000 (02:00 -0700)
committerLinus Torvalds <torvalds@g5.osdl.org>
Fri, 29 Sep 2006 16:18:16 +0000 (09:18 -0700)
commit416bc51292f977b43b010c6dd937522b90062390
tree012c8df7f762fedb8a2bcd027fa3e8a228bc49d0
parentcf3e43dbe0cc4a7ee7f6ab1bb5231dcfda164e02
[PATCH] Use decimal for PTRACE_ATTACH and PTRACE_DETACH.

It is sure confusing that linux/ptrace.h has:
#define PTRACE_SINGLESTEP    9
#define PTRACE_ATTACH 0x10
#define PTRACE_DETACH 0x11
#define PTRACE_SYSCALL   24
All the low-numbered constants are in decimal, but the last two in hex.
It sure makes it likely that someone will look at this and think that
9, 10, 11 are used, and that 16 and 17 are not used.

How about we use the same notation for all the numbers [0,24] in the
same short list?

Signed-off-by: Roland McGrath <roland@redhat.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
include/linux/ptrace.h