]> err.no Git - linux-2.6/commit
tcp: de-bloat a bit with factoring NET_INC_STATS_BH out
authorPavel Emelyanov <xemul@openvz.org>
Thu, 3 Jul 2008 08:05:41 +0000 (01:05 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 3 Jul 2008 08:05:41 +0000 (01:05 -0700)
commit40b215e594b65a3488576c9d24b367548e18902a
tree251b8247f97494b7461acc431044e81c33470254
parentb4653e99450693b75a3c6c8ff4f070164f12815e
tcp: de-bloat a bit with factoring NET_INC_STATS_BH out

There are some places in TCP that select one MIB index to
bump snmp statistics like this:

if (<something>)
NET_INC_STATS_BH(<some_id>);
else if (<something_else>)
NET_INC_STATS_BH(<some_other_id>);
...
else
NET_INC_STATS_BH(<default_id>);

or in a more tricky but still similar way.

On the other hand, this NET_INC_STATS_BH is a camouflaged
increment of percpu variable, which is not that small.

Factoring those cases out de-bloats 235 bytes on non-preemptible
i386 config and drives parts of the code into 80 columns.

add/remove: 0/0 grow/shrink: 0/7 up/down: 0/-235 (-235)
function                                     old     new   delta
tcp_fastretrans_alert                       1437    1424     -13
tcp_dsack_set                                137     124     -13
tcp_xmit_retransmit_queue                    690     676     -14
tcp_try_undo_recovery                        283     265     -18
tcp_sacktag_write_queue                     1550    1515     -35
tcp_update_reordering                        162     106     -56
tcp_retransmit_timer                         990     904     -86

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp_input.c
net/ipv4/tcp_output.c
net/ipv4/tcp_timer.c