]> err.no Git - linux-2.6/commit
[ICMP]: Pass proper ICMP socket into icmp(v6)_xmit_(un)lock.
authorDenis V. Lunev <den@openvz.org>
Fri, 29 Feb 2008 19:16:46 +0000 (11:16 -0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 29 Feb 2008 19:16:46 +0000 (11:16 -0800)
commit405666db84b984b68fc75794069f424c02e5796c
treed764573e97686f02c2a47fc7da96aefe97cbc458
parentb7e729c4b4778aac4dbbec9dc070acde93071f4d
[ICMP]: Pass proper ICMP socket into icmp(v6)_xmit_(un)lock.

We have to get socket lock inside icmp(v6)_xmit_lock/unlock. The socket
is get from global variable now. When this code became namespaces, one
should pass a namespace and get socket from it.

Though, above is useless. Socket is available in the caller, just pass
it inside. This saves a bit of code now and saves more later.

add/remove: 0/0 grow/shrink: 1/3 up/down: 1/-169 (-168)
function                                     old     new   delta
icmp_rcv                                     718     719      +1
icmpv6_rcv                                  2343    2303     -40
icmp_send                                   1566    1518     -48
icmp_reply                                   549     468     -81

Signed-off-by: Denis V. Lunev <den@openvz.org>
Acked-by: Daniel Lezcano <dlezcano@fr.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/icmp.c
net/ipv6/icmp.c