]> err.no Git - linux-2.6/commit
[PATCH] fix kill_proc_info() vs CLONE_THREAD race
authorOleg Nesterov <oleg@tv-sign.ru>
Wed, 15 Feb 2006 19:13:24 +0000 (22:13 +0300)
committerLinus Torvalds <torvalds@g5.osdl.org>
Wed, 15 Feb 2006 18:21:23 +0000 (10:21 -0800)
commit3f17da699431ec48540beabc55c54d4b5e66c8e7
tree0cc68e5daea5d4532a0225aa47cce193a32f6655
parent7775aa7690c26b3c5606090a43533a7a7429eb91
[PATCH] fix kill_proc_info() vs CLONE_THREAD race

There is a window after copy_process() unlocks ->sighand.siglock
and before it adds the new thread to the thread list.

In that window __group_complete_signal(SIGKILL) will not see the
new thread yet, so this thread will start running while the whole
thread group was supposed to exit.

I beleive we have another good reason to place attach_pid(PID/TGID)
under ->sighand.siglock. We can do the same for

release_task()->__unhash_process()

de_thread()->switch_exec_pids()

After that we don't need tasklist_lock to iterate over the thread
list, and we can simplify things, see for example do_sigaction()
or sys_times().

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Roland McGrath <roland@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
kernel/fork.c