]> err.no Git - linux-2.6/commit
[PATCH] pid: replace is_orphaned_pgrp with is_current_pgrp_orphaned
authorEric W. Biederman <ebiederm@xmission.com>
Mon, 12 Feb 2007 08:52:58 +0000 (00:52 -0800)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Mon, 12 Feb 2007 17:48:32 +0000 (09:48 -0800)
commit3e7cd6c413c9e6fbb5e1ee2acdadb4ababd2d474
treede97d00794ee0c787b6c551a91e33fb1faa48caa
parent0475ac0845f9295bc5f69af45f58dff2c104c8d1
[PATCH] pid: replace is_orphaned_pgrp with is_current_pgrp_orphaned

Every call to is_orphaned_pgrp passed in process_group(current) which is racy
with respect to another thread changing our process group.  It didn't bite us
because we were dealing with integers and the worse we would get would be a
stale answer.

In switching the checks to use struct pid to be a little more efficient and
prepare the way for pid namespaces this race became apparent.

So I simplified the calls to the more specialized is_current_pgrp_orphaned so
I didn't have to worry about making logic changes to avoid the race.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Oleg Nesterov <oleg@tv-sign.ru>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/char/n_tty.c
drivers/char/tty_io.c
include/linux/tty.h
kernel/exit.c
kernel/signal.c