]> err.no Git - linux-2.6/commit
fs: buffer don't PageUptodate without page locked
authorNick Piggin <npiggin@suse.de>
Sun, 6 May 2007 21:49:05 +0000 (14:49 -0700)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Mon, 7 May 2007 19:12:51 +0000 (12:12 -0700)
commit3d67f2d7c0fb28b0eb6a6aa100b190526a971ad9
treeeea6afc9610ba15218c9f03aa6091ec687a39577
parent6fe6900e1e5b6fa9e5c59aa5061f244fe3f467e2
fs: buffer don't PageUptodate without page locked

__block_write_full_page is calling SetPageUptodate without the page locked.
This is unusual, but not incorrect, as PG_writeback is still set.

However the next patch will require that SetPageUptodate always be called with
the page locked.  Simply don't bother setting the page uptodate in this case
(it is unusual that the write path does such a thing anyway).  Instead just
leave it to the read side to bring the page uptodate when it notices that all
buffers are uptodate.

Signed-off-by: Nick Piggin <npiggin@suse.de>
Cc: Hugh Dickins <hugh@veritas.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/buffer.c