]> err.no Git - linux-2.6/commit
[UDP]: Fix length check.
authorPatrick McHardy <kaber@trash.net>
Wed, 11 Jul 2007 06:06:43 +0000 (23:06 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 11 Jul 2007 06:06:43 +0000 (23:06 -0700)
commit3be550f34b03e5eb762f74d447ebbeba97efbd6d
tree07881880089af5f9d8dbea1444f09e34a0100ef1
parentdffe4f048b420f1af0b10a6090add0c5ea69e585
[UDP]: Fix length check.

RĂ©mi Denis-Courmont wrote:
> Right. By the way, shouldn't "len" rather be signed in there?
>
>  unsigned int len;
>
>  /* if we're overly short, let UDP handle it */
>  len = skb->len - sizeof(struct udphdr);
>  if (len <= 0)
>  goto udp;

It should, but the < 0 case can't happen since __udp4_lib_rcv
already makes sure that we have at least a complete UDP header.

Anyways, this patch fixes it.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/udp.c