]> err.no Git - linux-2.6/commit
x86: invalidate caches before going into suspend
authorMark Langsdorf <mark.langsdorf@amd.com>
Thu, 14 Aug 2008 14:11:26 +0000 (09:11 -0500)
committerIngo Molnar <mingo@elte.hu>
Fri, 15 Aug 2008 12:04:30 +0000 (14:04 +0200)
commit394a15051c33f2b18e72f42283b36a9388fa414b
tree3e0b4acbd9e940758b184991d78bfe8f3a168050
parentdcc984166870150709f0c645b521a47becd9a047
x86: invalidate caches before going into suspend

When a CPU core is shut down, all of its caches need to be flushed
to prevent stale data from causing errors if the core is resumed.
Current Linux suspend code performs an assignment after the flush,
which can add dirty data back to the cache.  On some AMD platforms,
additional speculative reads have caused crashes on resume because
of this dirty data.

Relocate the cache flush to be the very last thing done before
halting.  Tie into an assembly line so the compile will not
reorder it.  Add some documentation explaining what is going
on and why we're doing this.

Signed-off-by: Mark Langsdorf <mark.langsdorf@amd.com>
Acked-by: Mark Borden <mark.borden@amd.com>
Acked-by: Michael Hohmuth <michael.hohmuth@amd.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
arch/x86/kernel/process_32.c
arch/x86/kernel/process_64.c
include/asm-x86/processor.h