]> err.no Git - linux-2.6/commit
[NET] tun/tap: fixed hw address handling
authorBrian Braunstein <linuxkernel@bristyle.com>
Thu, 26 Apr 2007 08:00:55 +0000 (01:00 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 26 Apr 2007 08:00:55 +0000 (01:00 -0700)
commit36226a8ded46b89a94f9de5976f554bb5e02d84c
tree44fcfa54c6300dc2a843537cafb4a6f0d7075566
parent48491e6bdb8fa73751cc95f740175ec799db5d55
[NET] tun/tap: fixed hw address handling

Fixed tun/tap driver's handling of hw addresses.  The hw address is stored
in both the net_device.dev_addr and tun.dev_addr fields.  These fields were
not kept synchronized, and in fact weren't even initialized to the same
value.  Now during both init and when performing SIOCSIFHWADDR on the tun
device these values are both updated.  However, if SIOCSIFHWADDR is
performed on the net device directly (for instance, setting the hw address
using ifconfig), the tun device does not get updated.  Perhaps the
tun.dev_addr field should be removed completely at some point, as it is
redundant and net_device.dev_addr can be used anywhere it is used.

Signed-off-by: Brian Braunstein <linuxkernel@bristyle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/tun.c