]> err.no Git - linux-2.6/commit
[PATCH] x86_64/i386: Remove preempt disable calls in lowlevel IPI
authorZwane Mwaikambo <zwane@arm.linux.org.uk>
Wed, 11 Jan 2006 21:43:09 +0000 (22:43 +0100)
committerLinus Torvalds <torvalds@g5.osdl.org>
Thu, 12 Jan 2006 03:01:57 +0000 (19:01 -0800)
commit329d400f47ddfe8ff599823d739c5c5565da3207
tree903b45e7ebcccbbd8172e207315c036ceb70f6e8
parent73ca5358aab55e2e29993a31f3776c54c05ae729
[PATCH] x86_64/i386: Remove preempt disable calls in lowlevel IPI

I noticed that some lowlevel send_IPI_mask helpers had a hotplug/preempt
race whereupon the cpu_online_map was read before disabling preemption;

...
cpumask_t mask = cpu_online_map;
int cpu = get_cpu();
cpu_clear(cpu, mask);
...

But then i realised that there is no need for these lowlevel functions to
be going through all this trouble when all the callers are already made
hotplug/preempt safe.

Signed-off-by: Zwane Mwaikambo <zwane@arm.linux.org.uk>
Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
arch/x86_64/kernel/genapic_cluster.c
arch/x86_64/kernel/genapic_flat.c
include/asm-i386/mach-default/mach_ipi.h