]> err.no Git - linux-2.6/commit
[PATCH] firmware: fix BUG: in fw_realloc_buffer
authorJeff Moyer <jmoyer@redhat.com>
Mon, 13 Feb 2006 22:52:38 +0000 (14:52 -0800)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 20 Mar 2006 21:42:58 +0000 (13:42 -0800)
commit30560ba6eda308c13a361d08eb5d4eaab94ab37e
tree2639a567018f690c725da11470d7d28392cbfee8
parent58d49283b87751f7af75e021a629dcddb027e8eb
[PATCH] firmware: fix BUG: in fw_realloc_buffer

The fw_realloc_buffer routine does not handle an increase in buffer size of
more than 4k.  It's not clear to me why it expects that it will only get an
extra 4k of data.  The attached patch modifies fw_realloc_buffer to vmalloc
as much memory as is requested, instead of what we previously had + 4k.

I've tested this on my laptop, which would crash occaisionally on boot
without the patch.  With the patch, it hasn't crashed, but I can't be
certain that this code path is exercised.

Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/base/firmware_class.c