]> err.no Git - linux-2.6/commit
[PATCH] knfsd: fix race related problem when adding items to and svcrpc auth cache
authorNeil Brown <neilb@suse.de>
Sat, 5 Aug 2006 19:14:29 +0000 (12:14 -0700)
committerLinus Torvalds <torvalds@g5.osdl.org>
Sun, 6 Aug 2006 15:57:47 +0000 (08:57 -0700)
commit2f34931fdc78b4895553aaa33748939cc7697c99
treec94736005fd9b9b67515c9e5518b3543d58ff488
parent9b7f750d446a717d4c8346fbb165b62661019b92
[PATCH] knfsd: fix race related problem when adding items to and svcrpc auth cache

If we don't find the item we are lookng for, we allocate a new one, and
then grab the lock again and search to see if it has been added while we
did the alloc.  If it had been added we need to 'cache_put' the newly
created item that we are never going to use.  But as it hasn't been
initialised properly, putting it can cause an oops.

So move the ->init call earlier to that it will always be fully initilised
if we have to put it.

Thanks to Philipp Matthias Hahn <pmhahn@svs.Informatik.Uni-Oldenburg.de>
for reporting the problem.

Signed-off-by: Neil Brown <neilb@suse.de>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
net/sunrpc/cache.c