]> err.no Git - linux-2.6/commit
[SCSI] fix proc_scsi_write to return "length" on success with remove-single-device...
authorJames Bottomley <James.Bottomley@steeleye.com>
Thu, 27 Apr 2006 19:07:49 +0000 (14:07 -0500)
committerJames Bottomley <jejb@mulgrave.il.steeleye.com>
Wed, 10 May 2006 15:22:30 +0000 (10:22 -0500)
commit2ca48a132167f9f12efba179382979aafde0ab36
tree4eb3bbce62ac02590d6b49e5529ff90c0253b0fd
parent665b44aee34e9f2c64558df4ec01d40576e45651
[SCSI] fix proc_scsi_write to return "length" on success with remove-single-device case

Problem spotted by: Suzuki K P <suzuki@in.ibm.com>

A zero return on success isn't correct for filesystem write functions.
They should either return negative error or the length of bytes
consumed.  Add code to convert our zero on success error return to
return the length of bytes passed in.

This fixes the following:

$ echo "scsi remove-single-device 0 0 3 0" > /proc/scsi/scsi
bash: echo: write error: No such device or address"

Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
drivers/scsi/scsi_proc.c